secret fields should be secret

master
Brady McDonough 2 years ago
parent 238e6e9757
commit 45e40e1753

@ -3,3 +3,4 @@
- Display is awful to code an open ended interface for, but I still should - Display is awful to code an open ended interface for, but I still should
- Error reporting should be enhanced, either through a messaging object or via `throw` - Error reporting should be enhanced, either through a messaging object or via `throw`
- The hash fed into the `_6238` object should be based on the hash referenced in the provisioning uri - The hash fed into the `_6238` object should be based on the hash referenced in the provisioning uri
- URI tests must be rewritten due to public/private changes in the Otpauth object

@ -6,10 +6,12 @@ use InvalidArgumentException;
class Otpauth class Otpauth
{ {
private readonly string $secret;
public function __construct( public function __construct(
public readonly string $userid, public readonly string $userid,
public readonly string $issuer, public readonly string $issuer,
public readonly string $secret, string $secret,
public readonly string $algorithm, public readonly string $algorithm,
public readonly int $digits, public readonly int $digits,
public readonly int $period, public readonly int $period,

@ -40,7 +40,6 @@ final class URITest extends TestCase
$provisioningUri = Otpauth::fromString($string); $provisioningUri = Otpauth::fromString($string);
$this->assertSame($provisioningUri->secret, $queryComponents['secret']);
$this->assertSame($provisioningUri->issuer, $queryComponents['issuer']); $this->assertSame($provisioningUri->issuer, $queryComponents['issuer']);
$this->assertSame($provisioningUri->digits, $queryComponents['digits']); $this->assertSame($provisioningUri->digits, $queryComponents['digits']);
$this->assertSame($provisioningUri->period, $queryComponents['period']); $this->assertSame($provisioningUri->period, $queryComponents['period']);
@ -76,7 +75,6 @@ final class URITest extends TestCase
$provisioningUri = Otpauth::fromString($string); $provisioningUri = Otpauth::fromString($string);
$this->assertSame($provisioningUri->secret, $queryComponents['secret']);
$this->assertSame($provisioningUri->algorithm, $queryComponents['algorithm']); $this->assertSame($provisioningUri->algorithm, $queryComponents['algorithm']);
$this->assertSame($provisioningUri->digits, $queryComponents['digits']); $this->assertSame($provisioningUri->digits, $queryComponents['digits']);
$this->assertSame($provisioningUri->period, $queryComponents['period']); $this->assertSame($provisioningUri->period, $queryComponents['period']);

Loading…
Cancel
Save